Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Fix IPv6 static routes tenants #1778

Merged
merged 3 commits into from
May 12, 2022
Merged

Fix(eos_designs): Fix IPv6 static routes tenants #1778

merged 3 commits into from
May 12, 2022

Conversation

onurgashi
Copy link
Contributor

@onurgashi onurgashi commented May 11, 2022 •
edited
Loading

Change Summary

Small typo noticed after the ipv6_tenants PR got pulled in. This fixes the ipv6 route command, as it was printing it as ip route.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

{%         if vrf.ipv6_static_routes is arista.avd.defined %}
ipv6_static_routes:
{%             for ipv6_static_route in vrf.ipv6_static_routes %}

Fixes

ip route vrf Tenant_D_OP_Zone ::/0 2001:db8:311::4 name IPv6-test-2
ip route vrf Tenant_D_OP_Zone 10.3.11.0/24 Vlan411 name VARP

How to test

Molecule eos_designs_test_units also tested on customer's repo.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@onurgashi onurgashi added the type: bug Something isn't working label May 11, 2022
@onurgashi onurgashi self-assigned this May 11, 2022
@onurgashi onurgashi requested a review from a team as a code owner May 11, 2022 06:53
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR labels May 11, 2022
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): Fix IPv6 static routes tenants Fix(eos_designs): Fix IPv6 static routes tenants May 11, 2022
emilarista
emilarista approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ClausHolbechArista
ClausHolbechArista approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @onurgashi next time add new keys (ipv6_static_routes) to a separate template named like the key. We can change this next time we come around :)

@ClausHolbechArista ClausHolbechArista merged commit fee35bf into aristanetworks:devel May 12, 2022
jonxstill pushed a commit to jonxstill/ansible-avd that referenced this pull request May 31, 2022
@onurgashi @jonxstill
Fix(eos_designs): Fix IPv6 static routes tenants (aristanetworks#1778)
575477e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilarista emilarista emilarista approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@onurgashi onurgashi

Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onurgashi @ClausHolbechArista @emilarista